change: [M3-6541] - eslint: consistent-type-imports #10540
Conversation
abailly-akamai
requested review from
hana-akamai and
carrillo-erik
and removed request for
a team
|
Coverage Report: ✅ |
|
Curious to hear your thoughts on microsoft/TypeScript#39861 (comment) |
|
@bnussman-akamai I agree it's mostly stylistic at this point (i was convinced there was another element to it, but maybe not or irrelevant to our bundling/compiling setup). I think that comment is obsolete however, since
isn't true anymore. Thing is, we have agreed and started to implement this style (and people usually point to it in code reviews), so this PR is for consistency sake. Not a hill i would die on, I was again mostly going for consistency here. I don't even know if we can go back to grouping imports via linting, so our options are: we leave things as is and we don't think about it and stop commenting on PRs OR we go with the lint rule. |
Description 📝
Tiny PR to start enforcing
consistent-type-importsthrough the codebase (import typefor type file)https://typescript-eslint.io/rules/consistent-type-imports
This will remain a warning it does not affect the developer experience negatively other than suggesting to make that change when creating or editing a file. It will also make it easier/quicker to fix those via shortcuts when encountered.
Changes 🔄
consistent-type-importswarning to oures-lintrulesPreview 📷
Include a screenshot or screen recording of the change
How to test 🧪
Verification steps
As an Author I have considered 🤔
Check all that apply